If a tree falls in a forest and no one is around to hear it, does the tree make a sound?
If a model is coded in OpenSees and no one pushes it upstream on GitHub, does the model exist?
Is there only the perception that the tree makes a sound and that the model is part of OpenSees?
With 391 forks of OpenSees as of this writing, I’d say a lot of trees have fallen and made no sound.
Oh, you say your code is not good enough for the main OpenSees. Well, your code was good enough to crank out a few manuscripts that got through peer review, right?
Or you think your code is inefficient and needs to be cleaned up. Ha! A lot of OpenSees models are inefficient and horrible to look at–mine included.
The bottom line is if you provide documentation and don’t pollute an interface, use friend classes, or break encapsulation, Frank and I will merge your pull request.
Keep your fork up to date with the main OpenSees–something you should always do before you start chopping trees.
Then, when you’re ready to initiate a pull request to add Concrete24 to OpenSees, do this with your
> git push --set-upstream origin concrete24
If you’ve already done this, you probably didn’t need to read this post in the first place.
To finalize the pull request, go to the GitHub webpage for your OpenSees fork, select the
concrete24 branch, then click “Make Pull Request”. Frank and I can handle it from there.
One thought on “Make a Pull Request”